Issue with string::operator[]

smize

#include <iostream>
#include <string>

using namespace std;

void str2hex(string str) {

int strlen = str.length(); // Assign the length of input/str to strlen
string hex[strlen]; // Initialize the Array hex with the length of the string


for (int x = 0; x < strlen; x++){ // Create a for loop assigning the values of the string to hex as hexadecimal values.


if (str[x] == " "){

hex[x] = 20;

}

}

}

int main()
{

string input; // Declaring the string which will be converted into HEX
getline(cin,input); // Gets the user's input for the string
str2hex(input); // Inserts the user's input into the str2hex function

return 0;
}




In this program the issue is occuring on the line with if(str[x] == " ") {

the error i'm getting is: comparison with string literal results in unspecified behaviour
I can't figure out what is wrong. I am new to C++ so please don't scold me. Thank - you.

Borek

Isn't str[x] a character? If so, you should compare it to a character ' ', not a string " ".

smize

Thank you very much! Works perfectly! I'm such a novice -.-