Troubleshooting Random Value Issues in C Code - Solutions and Explanation

[Nobody]

Thanks for the help
I have another problem,

int foo(){
int n=rand()%2
switch(n){
case 0:
h=1;
break;
case 1;
h=0;
}
return h;
}

void mat(int a[][5]){
for(i=0;i<5;i++)
for(j=0;j<5;j++)
a[j]=foo();
}


And in main function I can only print out all 0's or all 1's. There are no random values at all ? Why no random values ?
If you can, please explain this in assembly code and in the above C code also, I'm very grateful.
Thanks a lot

 

[Nobody]

Please help me, Okay ?
Thank you...

 

[dduardo]

Huh? rand()%2 will return 0 and 1 and this value is stored in n. The case statement is just inverting the n variable. You can actually invert the bit in one line by doing:

n = !n

I would add an srand() in the foo function to seed the rand number generator.

 

[Nobody]

No it didn't work. Can you check it out again for me ?
Thanks

 

[TenaliRaman]

What exactly are u looking for ?
first of all as dduardo say,
use srand()
secondly,
a call to randomize() is also needed...

Also u say that u are getting only 1's and 0's ...
if u don't know then that's what exactly ur program is programmed to do ...
note that ur foo is returning 1 and 0's only.

-- AI

 

[chronon]

case 1;
h=0;

What you posted had a syntax error. That means that is wasn't cut and pasted directly from the source of the program that you ran. Since we're not seeing the actual code, it makes it hard to know what the problem is.

 

[Nobody]

I code my program in another computer, not this one.

int foo(){
srand(usignged(time(NULL));
int n=rand()%2;
switch(n){
case 0:
h=1;
break;
case 1:
h=0;
}
return h;
}

void mat(int a[][5]){
for(int i=0;i<5;i++)
for(int j=0;j<5;j++)
a[j]=foo();
}

In my main function

int main(){
int a[3][5];
mat(a);
for(int i=0;i<5;i++)
for(int j=0;j<5;j++)
std::cout<<a[j]<<" ";
return 0;
}

I can only see alll 1's, I execute again and only see all 0's.

What happens ?
Thanks.

 

[chronon]

srand(usignged(time(NULL));
int n=rand()%2;

Each time you generate a random number you are resetting the random number generator with the same seed. The seed is the integer value of the number of seconds since the start of 1970, and won't change during the running of the program.

 

[Nobody]

Thank you, chronon.
But does that also mean I have to rewrite the program ? Do you know how to change the program above to make that random number generator work for me ?

 

[Dr-NiKoN]

Example code.

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
  int i;

  /* seed */
  srandomdev();

  /* Get 10 random numbers (either 1 or 0) */
  for(i = 0; i < 10; i++)
    printf("%d\n", (int)random()%2 );

  return 0;
}

If you want the numbers to vary between 0 and 1, you could so something like:
(changes in bold)

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
  int i;

  /* seed */
  srandomdev();

  /* Get 10 random numbers */
  for(i = 0; i < 10; i++)
    printf("[b]%f[/b]\n", [b](float)random()/RAND_MAX[/b] );

  return 0;
}