How can I fix an error in the insertion sort while loop in a Java program?

[apiwowar]

So i haven't done java in about two years, its been a while since I've seen arrays. THe assignment is to fix a program that was given to me. I found one error but in the insertion sort part i can't get it to run the while loop. I can't make any fundamental changes to the program, basically i just have to fix the error in the while loop to get it running.

any pointers or advice would be appreciated, just need a kick in the right direction.

below is the program



import java.io.*; // for BufferedReader
import java.util.*; // for StringTokenizer

public class Prog1Original { // A simple program with no classes

public static void main(String[] args) throws IOException {

int number[] = new int[100];
int ct, num, size, i, j, insel;
BufferedReader stdin = new BufferedReader(
new InputStreamReader(System.in) );

System.out.print("Input integers: ");
size = 0; // The smallest index of an array is always 0
String inputLine = stdin.readLine(); // All input must be on a single line
StringTokenizer input = new StringTokenizer(inputLine);
while (input.hasMoreTokens()) { // extract the integers from the input line

num = Integer.parseInt(input.nextToken());
number[size] = num;
size = size + 1;
}
System.out.println();
System.out.print("The original numbers: ");
for (ct = 0; ct < size; ct++) {
System.out.print(number[ct]);
System.out.print(" ");
}
System.out.println();

// "Insertion Sort" the numbers
for (i = 1; i < size; i++) { // Starting with the second array element
insel = number;
j = i;
while ( (number[j] > insel) && (j >= 0) ) { // shift larger elements right
number[j + 1] = number[j];
j = j - 1;
}
number[j] = insel; // insert the number to its proper place
}
System.out.print("The sorted numbers: "); // Output the sorted array
for (ct = 0; ct < size; ct ++) {
System.out.print(number[ct]);
System.out.print(" ");
}
System.out.println();
}
}

 

[Mark44]

I added (code) and (/code) tags (but in square brackets) to preserve your original formatting.

So i haven't done java in about two years, its been a while since I've seen arrays. THe assignment is to fix a program that was given to me. I found one error but in the insertion sort part i can't get it to run the while loop. I can't make any fundamental changes to the program, basically i just have to fix the error in the while loop to get it running.

any pointers or advice would be appreciated, just need a kick in the right direction.

below is the program

import java.io.*;    // for BufferedReader
import java.util.*;  // for StringTokenizer

public class Prog1Original { // A simple program with no classes

   public static void main(String[] args) throws IOException {

      int number[] = new int[100];
      int ct, num, size, i, j, insel;
      BufferedReader stdin = new BufferedReader(
         new InputStreamReader(System.in) );

      System.out.print("Input integers: ");
      size = 0;  // The smallest index of an array is always 0
      String inputLine = stdin.readLine();    // All input must be on a single line
      StringTokenizer input = new StringTokenizer(inputLine);
      while (input.hasMoreTokens()) {  // extract the integers from the input line
         
         num = Integer.parseInt(input.nextToken());
         number[size] = num;
         size = size + 1;
      }
      System.out.println();
      System.out.print("The original numbers: ");
      for (ct = 0; ct < size; ct++) {
         System.out.print(number[ct]);
         System.out.print("  ");
      }
      System.out.println();

       // "Insertion Sort" the numbers
      for (i = 1; i < size; i++) { // Starting with the second array element
         insel = number[i];
         j = i;
         while ( (number[j] > insel) && (j >= 0) ) { // shift larger elements right
            number[j + 1] = number[j];
            j = j - 1;
         }
         number[j] = insel;  // insert the number to its proper place
      }
      System.out.print("The sorted numbers: ");  // Output the sorted array
      for (ct = 0; ct < size; ct ++) {
         System.out.print(number[ct]);
         System.out.print("  ");
      }
   System.out.println();
   }
}

Can you give more details about what you mean that you can't get it to run the while loop. If a while loop isn't executing, it's because the test condition at the top of the loop is false. That means that number[j] <= insel or j < 0, or both.

 

[apiwowar]

i put in System.out.print(" " + j); into the while loop to see if it would print out anything while doing the loop. my thinking was that if it did then the program goes through the loop but it didnt print that out which leads me to think that it doesn't go through the loop.

 

[Mark44]

Right. If you don't have a debugger to work with, or do have one but don't know how to use it, put a print statement just before the start of the loop to display the values of j and number[j].

If you have a debugger available, it would be a very good idea to learn how to use it.

 

[DeeNos]

As a scientist, my advice would be to first understand the purpose and logic behind the insertion sort algorithm. This will help you identify any potential errors in the code and make the necessary changes. Additionally, it might be helpful to review the basics of arrays in Java to refresh your memory. You can also try debugging the code by printing out the values of the variables at each step to see where the error is occurring. Finally, don't be afraid to ask for assistance from your colleagues or online resources. With some persistence and effort, you should be able to fix the error and get the program running smoothly.