C while loop issue

  • Thread starter Vavotaj
  • Start date
  • #1
14
0
#include <stdio.h>
#include <string.h>

double faktoriel (double y);

void main()
{
double x, fac;
char yes[5] ="yes";
char answer[5];

do
{
printf("Enter number:\n");
scanf("%f", &x);

while (50>x || x>100)
{
printf("Number doesn't match \n"); //50<x<100
printf("Enter number again:\n");
scanf("%f", &x);
}
fac = faktoriel (x);
}while(strcmp (yes, answer)!=0);
return;
}

double faktoriel (double y)
{
double i, factor;


for(i=y; i>1; i--)
{
factor*=i;
}
printf("%f", factor);
return factor;
}
----------------------------------------------------------------------------------------
There are proly many mistakes xD
 

Answers and Replies

  • #2
Borek
Mentor
28,507
2,934
while (50>x || x>100)
//50<x<100
No idea what you are trying to do, but this is inconsistent.
 
  • #3
14
0
to ppl enter number lower than 100 higher than 50
 
  • #4
Borek
Mentor
28,507
2,934
x>100 doesn't mean lower than 100.
 
  • #5
14
0
but while x is higher than 100 or lower than 50 to to that code
 
  • #6
14
0
or how should it be done ?
 
  • #7
KTC
90
0
Code:
x > 100
means precisely what it suggest, x is greater than 100.

And || is OR, I think you were wanting && (AND).
 
  • #8
chroot
Staff Emeritus
Science Advisor
Gold Member
10,226
34
The line of code that Borek pointed out is, in fact, correct. It will keep asking the user to enter a value until it's between 50 and 100.

Your post contains no questions, though, so I have no idea what you want from us.

- Warren
 
  • #9
Borek
Mentor
28,507
2,934
The line of code that Borek pointed out is, in fact, correct.
Oops, sorry. I was absolutely sure it was x>50 || x>100. Must be senior moment :eek:
 
  • #10
14
0
than why it is always repeating it self even if i enter number between 50 and 100 ?
 
  • #11
14
0
for exaple :
#include <stdio.h>

main()
{
double x;

printf("Enter number:");
scanf("%f", &x);

while (50>x || x>100)
{
printf("Number doesn't match \n");
printf("Enter number again:\n");
scanf("%f", &x);
}
}
 
  • #12
14
0
it works with int ... why it doesn't work with double ?
 
  • #13
D H
Staff Emeritus
Science Advisor
Insights Author
15,393
684
It is always a good idea to run a program with a debugger. If you do this you will find that the value of x is nowhere close to the value you typed in. Hint: Your example program will work if you change x from a double to a float.
 
  • #14
14
0
but how do i do it in double ?
 
  • #15
68
0
You write programs to solve problems. Based on the complexity of your problem, you devise a solution that is most efficient/productive. What is your problem?
 
  • #16
14
0
my professor ... he demands double :grumpy:
 
  • #17
14
0
ah solution :
#include <stdio.h>

main()
{
float x;


(double) x;
printf("Enter number:");
scanf("%f", &x);
while (50>=x || x>=100)
{
printf("Number doesn't match \n");
printf("Enter number again:\n");
scanf("%f", &x);
}
}
:)
 
  • #18
D H
Staff Emeritus
Science Advisor
Insights Author
15,393
684
but how do i do it in double ?
I could tell you right now how to solve this problem, but that will not help you solve related problems in the future. You need to learn how to use reference material. There is no way to keep all the stuff associated with a language and its associated libraries in your head. The ability to quickly look things up in the reference material is key to having any success in programming.


So, I will instead tell you to RTFM: Read The Fine (or if you prefer, some other F word that is a tad more vulgar) Manual. I'll even give a specific thing to read up on this time: scanf. If you are still vexed, ask again, but please only do so after you have read the documentation.
 
  • #19
D H
Staff Emeritus
Science Advisor
Insights Author
15,393
684
my professor ... he demands double :grumpy:
ah solution :
float x;


(double) x;
You will (or at least should) get points off if you offer this as your solution. In particular, (double) x; does absolutely nothing useful. In particular, it is not doing what your professor has asked of you.
 
  • #20
14
0
All i have bout scanf is int, char and float ... double is not mentioned :grumpy:
 
  • #21
Borek
Mentor
28,507
2,934
10 seconds googling.

http://www.rt.com/man/scanf.3.html [Broken]
 
Last edited by a moderator:
  • #22
14
0
Solution :

#include <stdio.h>

main()
{
double x;
printf("Enter number:");
scanf("%lf", &x);
while (50>=x || x>=100)
{
printf("Number doesn't match \n");
printf("Enter number again:\n");
scanf("%lf", &x);
}
}
 
  • #23
14
0
Solution :

#include <stdio.h>

main()
{
double x;



printf("Enter number:");
scanf("%lf", &x);
while (50>=x || x>=100)
{
printf("Number doesn't match \n");
printf("Enter number again:\n");
scanf("%lf", &x);
}
}
 
  • #24
D H
Staff Emeritus
Science Advisor
Insights Author
15,393
684
Excellent. RTFM is a powerful technique. Except when the Fine Manual is not so fine, that is.
 
  • #25
14
0
Actualy Lousy Manual didn't have it so i looked at google more precise xD
 

Related Threads on C while loop issue

Replies
4
Views
10K
Replies
3
Views
5K
  • Last Post
Replies
11
Views
906
  • Last Post
Replies
6
Views
2K
  • Last Post
Replies
4
Views
2K
Replies
7
Views
6K
Replies
7
Views
6K
  • Last Post
Replies
15
Views
4K
Replies
8
Views
1K
Replies
11
Views
648
Top