• Support PF! Buy your school textbooks, materials and every day products Here!

Java - trouble debugging

  • Comp Sci
  • Thread starter schapman22
  • Start date
  • #1
74
0

Homework Statement



We must make a class used to evaluate a polynomial function of x. My problem is I am getting an array out of bounds exception when I run the main, and I can't figure out why.
If you could help me figure out this out of bounds exception it would be very appreciated thank you.

Homework Equations



ex. P(x)= a0 + a1x + a2x2...

The Attempt at a Solution



This is the class

Code:
public class Polynomial 
{
    private int degree, i=0, size;
    private double answer;
    private double[] coefficient = new double[size];
    
    public Polynomial(int max)
    {
        if(degree>=0) 
            degree = max;
        size=max+1;
               
    }
    
    public void setConstant(int subscript, double value)
    {
        i = subscript;
        coefficient[i] = value;        
    }
    
    public double evaluate(int x)
    {
        for(int index=0;index<coefficient.length;index++)
        {
            answer = coefficient[index] * (Math.pow(x, degree));
        }
            return answer;        
    }
}
This is the main

Code:
public class PolynomialDemo 
{

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) 
    {
        Polynomial p = new Polynomial(3);
        
        p.setConstant(0, 3);
        p.setConstant(1, 5);
        p.setConstant(2, 0);
        p.setConstant(3, 2);
        
        System.out.println(p.evaluate(7));
    }
}
 
Last edited:

Answers and Replies

  • #2
54
0
It is because the length of the array coefficient is zero!

When you are creating the object of the class Polynomial, you are calling the constructor and it is updating the value of "size" but not the creating an array "coefficient" of length "size".


It will be better if you define the length of the "coefficient" array inside the constructor.
therefore the correct version should look like this:

private double[] coefficient ;

public Polynomial(int max)
{
if(degree>=0)
degree = max;
size=max+1;
coefficient = new double[size];

}
 
  • #3
33,310
5,004

Homework Statement



We must make a class used to evaluate a polynomial function of x. My problem is I am getting an array out of bounds exception when I run the main, and I can't figure out why.
If you could help me figure out this out of bounds exception it would be very appreciated thank you.

Homework Equations



ex. P(x)= a0 + a1x + a2x2...

The Attempt at a Solution



This is the class

Code:
public class Polynomial 
{
    private int degree, i=0, size;
    private double answer;
    private double[] coefficient = new double[size];
    
    public Polynomial(int max)
    {
        if(degree>=0) 
            degree = max;
        size=max+1;
               
    }
    
    public void setConstant(int subscript, double value)
    {
        i = subscript;
        coefficient[i] = value;        
    }
    
    public double evaluate(int x)
    {
        for(int index=0;index<coefficient.length;index++)
        {
            answer = coefficient[index] * (Math.pow(x, degree));
        }
        return answer;        
    }
}
This is the main

Code:
public class PolynomialDemo 
{

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) 
    {
        Polynomial p = new Polynomial(3);
        
        p.setConstant(0, 3);
        p.setConstant(1, 5);
        p.setConstant(2, 0);
        p.setConstant(3, 2);
        
        System.out.println(p.evaluate(7));
    }
}
The problem seems to be that your constructor does not initialize degree. Here's what I think is going wrong.
In main:
Code:
Polynomial p = new Polynomial(3);
This causes the constructor to be called, with the max parameter set to 3.
Code:
public Polynomial(int max)
{
    if(degree>=0) 
         degree = max;
    size=max+1;
}
Since degree is uninitialized, there's no telling whether degree>=0 will be true. I'm not sure what the purpose of the max variable is - it could possibly be eliminated altogether, and you could have the parameter of the constructor be degree.
 
  • #4
74
0
Thank you, and now, that example i used in the main should set a polynomial like
P(x) = 3 + 5x + 2x^3 and when i evaluate for x=7 should result in 724, but i'm getting 686 which is just 2x^3. Can anyone see what I did wrong?
 
  • #5
74
0
Never mind it works properly now. Revised the code to this.
Code:
public class Polynomial 
{
    private int degree, i=0, size;
    private double answer;
    private double[] coefficient = new double[size];
    
    public Polynomial(int max)
    {
        if(max>=0) 
            degree = max;
        size=max+1;
        coefficient = new double[size];
    }
    
    public void setConstant(int subscript, double value)
    {
        i = subscript;
        coefficient[i] = value;        
    }
    
    public double evaluate(int x)
    {
        for(int index=degree;index>=0;index--)
        {
            answer += coefficient[index] * (Math.pow(x, degree));
            degree--;
        }
            return answer;        
    }
}
 
  • #6
33,310
5,004
The parameter of your evaluate method should be double instead of int, so that you can evaluate the polynomial at values such as 2.5.
 
  • #7
74
0
Ok I will do that thank you.
 

Related Threads on Java - trouble debugging

Replies
2
Views
2K
Replies
3
Views
2K
  • Last Post
Replies
6
Views
4K
Replies
16
Views
7K
Replies
2
Views
841
  • Last Post
Replies
3
Views
1K
Replies
1
Views
3K
Replies
1
Views
1K
  • Last Post
Replies
6
Views
600
Top