program to read file

neo programmer

hi! i was writing a program which asks the user to input the file name. the program then reads the file and prints out how many times each characeter has occured in the file(uppercase and lowercase are different). Pls help me out.
this is what i have got-i know this is not correct.

#include<iostream>
#include<fstream>
#include<stdlib.h>

using namespace std;

int main()
{
fstream file_ptr;
char filename[81];
int a = 65;
int e=0;
char number[58]={0};
for(int i=0; i<58; i++)
{
number[i]=a;
a++;
}
// Get name of file
cout << "Enter filename : ";
cin.getline(filename,81);
// Open data file for READING
cout << "Opening file "<< filename << endl;
file_ptr.open(filename, ios::in);
if (!file_ptr.good())
{
//The file could not be opened
cout << "ERROR - file " << filename << " could not be opened";
exit(1);
}
// READ data from file until the end-of-file (EOF) is reached.

do {
file_ptr >> number;
cout << "Read " << number << " from file." << endl;
} while(file_ptr.peek()!=EOF);
// Close file
cout << "Closing file " << filename << endl;
file_ptr.close();
system("pause");
return 0;
}

KTC

Why 81? What's 81 char big? Don't use magic number.

Why 65? What's 65? Don't use magic number. You don't need to tell the program what it's internal representation is in numerically for characters. Use char's and it'll work it out itself.

What's e? Where have you used it?

Why 58? What's 58? Don't use magic number.

Don't need that.

Use std::string, and not some random arbitrary length for the filename.

>> reads in from the first non-whitespace character until the next non-whitespace character. number confusing though you've made it, is char array of 58 char's long. You're wanting to read in each character one at a time, and count it. Why are you reading in phase at a time?

pmbasa

hmm, man, I hate C++. C++ is way too overloaded (it's a joke). Try placing comments or exlanations on each part of your code, so you, yourself, and others know what a section does. Look at all those questions by KTC. Try simplifying your code, or remove code that isn't really needed. And I believe, C++ has helper functions for getting on a character by character basis. Anyway, I'll check again and post here another time.

neo programmer

this is something different which i wrote

#include<iostream>
#include<fstream>
#include<stdlib.h>

using namespace std;

int main()
{
fstream file_ptr;
char filename[81];
// Get name of file
cout << "Enter the filename (make sure that the test file and the program is in the same directory): ";
cin.getline(filename,81);
// Open data file for READING
cout << "Opening file "<< filename << endl;
file_ptr.open(filename, ios::in);
if (!file_ptr.good())
{
//The file could not be opened
cout << "ERROR - file " << filename << " could not be opened";
exit(1);
}
int a = 65;
char number[58]={0};
for(int i=0; i<58; i++)
{
number[i]=a;
a++;
}
int x[58]={0};
char c;
// READ data from file until the end-of-file (EOF) is reached.
while(file_ptr.eof()==0)
{
file_ptr.get(c); //reading character
for(int i=0; i<58; i++)
{
if(number[i]==c)
{
x[i]=x[i]+1;
break;
}
}
}
for(int i=0; i<58; i++)
{
cout<<number[i]<<"="<<x[i]<<endl;
}

// Close file
cout << "Closing file " << filename << endl;
file_ptr.close();
system("pause");
return 0;
}

neo programmer

i took 65 because 65 is ASCII equivalent of 'a'. as i wnt to get all the alphabets(both uppercase and lowercase) so i used size of d array as 58.
65 + 58 =123 which is ASCII equivalent of 'Z'.

i still dont know how to correct the filename part in d code.

jtbell

When reading files using a "while" loop in C++, it is almost never a good idea to use the eof() member function or the predefined EOF symbol, because it gives you "true" only after the program has tried to read past the end of file and failed. Therefore the loop makes one more cycle after the last real data item, giving you some garbage input.

In your case, the usual way to read one character at a time is:

When you use any of the standard C++ input operations in a boolean context, it evaluates as "true" or "false" depending on whether the operation succeeded or not, in addition to actually performing the input operation. Therefore, when file_ptr.get() tries to read past the last character in the file, it fails, and the loop terminates immediately without trying to do anything with the garbage that is now in c.

The appropriate way to use eof() is to test whether the loop ended because of end of file or some other kind of input error: