• Support PF! Buy your school textbooks, materials and every day products Here!

Why is my if statement executing when its false

  • Thread starter ProPatto16
  • Start date
  • #1
326
0
quick question, not sure why i cant work this out.
in the following code my if statement executes, but as far as i can see i have set the boolean so that it shouldnt.
Code:
public void actionPerformed(ActionEvent e)
               {
                   boolean contains = false; 
                   for (int i = 0; i < studentStrings.size(); i++)
                    {
                        if( studentStrings.get(i).contains( enterID.getText()))
                        {
                            System.out.println( " get constains executed");
                            contains = true;
                        }
                    }
                    if ( contains = true)
                    {
                        updateOldRecord();
                        System.out.println( "if executed");
                    }
                    else
                    {
                        newRecord();
                        System.out.println( "else executed");
                    }
you can see there are 2 ifs and one else. When and if the first one executes it should set the boolean contains to true. then if boolean contains is true my second if should execute and not my else. and if the first if doesnt execute the boolean should still be false so my else will execute. the system.print methods are just so i can see which ones are executing.

in the for statement the idea is i look for a string in the arrayList that is entered into a student ID text field. if the ID already exists it updates that student, if not it creates a new record.

the problem is whether or not that first if statement executes, only my second if executes, never the else.

so if my jtextfield has an existing ID number executed i get

get contains executed
if executed

and if it does not contain an existing ID then boolean should remain false and then only execute the else but i get

if executed.


i dont know why my if statement arguments arent working?

thanks

Homework Statement





Homework Equations





The Attempt at a Solution

 

Answers and Replies

  • #2
gabbagabbahey
Homework Helper
Gold Member
5,002
6
You are missing an equals sign. If (contains = true) sets contains equal to true and then tests whether it is true. If (contains == true) just tests whether contains is true without changing its value.
 
  • #3
760
69
Code:
There is a difference between assignment and comparison.

The expression of assigning a boolean can be treated as a boolean.

Code:
boolean b = false;

if( b = true) //expression in () sets b to true and evaluates to true
{
    System.out.println( "THIS LINE WOULD GET PRINTED");
}

As an aside, one may write
Code:
if(b == true)
more concisely as
Code:
if(b)
 
  • #4
326
0
Thanks, knew it would be simple!
 

Related Threads on Why is my if statement executing when its false

Replies
23
Views
1K
Replies
1
Views
407
  • Last Post
Replies
2
Views
1K
  • Last Post
Replies
4
Views
1K
Replies
21
Views
2K
Replies
3
Views
4K
  • Last Post
Replies
2
Views
1K
Replies
3
Views
1K
  • Last Post
Replies
3
Views
1K
  • Last Post
Replies
0
Views
4K
Top