C linked list with an array inside

[baddin]

I have pasted my code here : http://pastebin.com/nMNarH9i
It is in language C.
Basically, I am reading in 5 numbers at a time.
Putting these numbers in array one_vote_array.
Then I need to put this array in a structure vote_node.
I also then change my next pointer in the structure to head and then make head point to this new structure.
I want to to keep on making structures while I keep reading in 5 numbers.
The problem is my program is only printing the last number i inputted in it.

 

[jedishrfu]

Clearly a case of voter fraud.

so the way your program is written it will print the voting backward right? last voter to first voter.

but in your case it prints the last voter and stops so that implies that the temp->next is null.

Id go back to the first for loop and use your print test to see what voter->node is beiing set to as you iterate thru your voters.

Do you have a debugger that you can run your program thru?

it would allow you to review the values of variables step by step.

 

[D H]

You are reusing the same array of five integers for each node. You need to allocate a new array of five integers for each node.

 

[jedishrfu]

You are reusing the same array of five integers for each node. You need to allocate a new array of five integers for each node.

Good catch, but I thought we were supposed to lead the OP to the answer.

 

[baddin]

But my function read_one_vote changes the contents of the array one_vote_array everytime it is called, so shouldn't that array be different for each node?

 

[D H]

How can it be different for each node? Your code makes exactly the opposite be true. It's the same array for each node.

If you need a different array for each node, you need to make a different array for each node.

 

[baddin]

Ok, I did what you said, and it works now. Thank you very much.

 

[baddin]

I still am finding it confusing though, can't I use the same array with different value and set it to each node?

 

[baddin]

Because the values of one_vote_array change each time the function read_one_vote gets called

 

[DimReg]

I still am finding it confusing though, can't I use the same array with different value and set it to each node?

Think about it at the hardware level: If you need to keep track of say, 9 different arrays, how many arrays would you need to allocate in memory? Each block of memory can only hold one value at a time, so in order for your computer to "remember" what the content of each array is, it needs to allocate a separate memory block for each one.

What your asking is possible though. If you want, you can have a buffer in which you construct each array you want. Then when it is ready, you can copy it to another newly allocated array, and reset the original array. However, this still requires you to allocate a new array each time.