Write this algorithm in pseudocode

[Travian]

hmmmm not sure at the moment. trying to figure out.

 

[Travian]

no idea actually.

 

[iamalexalright]

Alright, so we know one of them will be the largest (multiples perhaps but we don't care about those).

We'll call this largest. Can we compare each number they enter to largest(which is the current largest) in the loop?

 

[Travian]

Alright, so we know one of them will be the largest (multiples perhaps but we don't care about those).

We'll call this largest. Can we compare each number they enter to largest(which is the current largest) in the loop?

ok, so i declare largestNumber as integer. Then i put in into a loop and compare as you say. But the problem is - i have to assign something to the largestNumber.

 

[iamalexalright]

well, first why don't we initialize it to zero.

Now how will you tell if a number entered is bigger than this? If it is, what do you do? If it isn't, what do you do?

 

[Travian]

I will use a boolean expression.

if largestNumber < Number then
largestNumber = Number + largestNumber
else
hmmmD

 

[Mark44]

Again I would emphasize that given the setup that OP gave called for arrays.

If by "setup" you mean the problem statement, you are confusing the requirements of the problem statements with an implementation. This problem can and should be done without arrays. That's the point that I and several other responders have been making.

I even thought that was the direction OP was going to. In this original post he was using a loop to cycle through an array he didn't create. Besides, i thought it would be better if i went along with OP thought process instead of giving him a totally different approach.

Then you and I disagree. In my view, Travian was heading down the wrong track. When that happens, the best thing is not to help him go in the wrong direction, but to steer him in the right direction.

Mark44 it was not a flawed interpretation . I belief he had the right idea but the execution was not satisfactory.

 

[Mark44]

I will use a boolean expression.

if largestNumber < Number then
largestNumber = Number + largestNumber
else
hmmmD

Try it with actual numbers.
1) Let largestNumber = 25 and Number = 28
What should happen?

2) Let largestNumber = 25 and Number = 23
What should happen?

 

[Travian]

Try it with actual numbers.
1) Let largestNumber = 25 and Number = 28
What should happen?

2) Let largestNumber = 25 and Number = 23
What should happen?

1) largestNumber becomes 28
2) largestNumber cannot be 25, because it became 28. i should have used while loop i think, not if statement.

 

[Travian]

Declare Counter as integer
Declare Number as float
Delare largestNumber as integer
Set Counter = 0
Set Number = -1
Set largestNumber = 0
Display "Enter a number. Enter a zero to finish"
WHILE Number != 0
    Get Number
    IF Number > 0 THEN
        Counter = Counter + Number
         IF largestNumber < Number THEN
             largestNumber = largestNumber + Number    
         ENDIF
    ENDIF
ENDWHILE
Display "The sum of positive numbers is: " + Counter  
Display “The largest number is “ + largestNumber

I can't think of anything else..

 

[iamalexalright]

I see one problem...

If largetsNumber < Number why do you then add number to largetsNumber and not just set largestNumber to number?

 

[Travian]

Then largestNumber == Number...
instead of largestNumber + Number
?

 

[Mark44]

Try it with actual numbers.
1) Let largestNumber = 25 and Number = 28
What should happen?

2) Let largestNumber = 25 and Number = 23
What should happen?

1) largestNumber becomes 28
2) largestNumber cannot be 25, because it became 28. i should have used while loop i think, not if statement.

No, IF statement is what you want. The examples above weren't necessarily in sequence. The idea was that in the first example, largestNumber should be reset. In the second example, largestNumber shouldn't be reset.

IF Number > largestNumber THEN
  largestNumber = Number
ENDIF

What's implied in code above is that if Number <= largestNumber, then don't do anything.

 

[Travian]

Declare Counter as integer
Declare Number as float
Delare largestNumber as integer
Set Counter = 0
Set Number = -1
Set largestNumber = 0
Display "Enter a number. Enter a zero to finish"
WHILE Number != 0
    Get Number
    IF Number > 0 THEN
        Counter = Counter + Number
        [b]IF (Number > largestNumber) THEN
            largestNumber = Number
        ENDIF[/b]    
    ENDIF
ENDWHILE
Display "The sum of positive numbers is: " + Counter  
Display “The largest number is “ + largestNumber

Ok i did all that. One last question. Is it correct to put if statement in another if statement, like i did (text emphasized in bold)

 

[Mark44]

Sure, you can do that.

 

[Travian]

Thank you guys, i appreciate your help.
I will recommend this forum to other people.