Code for checking for pythogrean triples.

  • Thread starter Thread starter MathematicalPhysicist
  • Start date Start date
  • Tags Tags
    Code
Join the discussion
Registration is free. Ask a follow-up in this thread, or start your own.
2 replies · 3K views
Messages
4,662
Reaction score
372
i was asked to write a code that search for pythogrean triples, my fault in my code is that i don't know where to write the codnition that a<b<c, cause as of now runs duplicates of pyhtogrean's triples.
here's the code:
Code:
main()
{
  int n,max,a,b,c;
 printf("insert the degree you wish to check for n-th pythogrean triplets\n");
 scanf("%d", &n);
 printf("insert the maximal number you want to check for\n");
 scanf("%d", &max);
 if(max>2){
   
   for(a=1;a<=max;a++)
     {
       for(b=2;b<=max;b++)
         {
   for(c=3;c<=max;c++)
     {
       if((pow(a,n)+pow(b,n)==pow(c,n))&& gcd(a,b)==1){
         f++;
         printf("the triplet is: %d, %d, %d \n", a,b,c);
       
       
     }
         }
     }
 }
}
any hints as to where to place this condition?
 
Physics news on Phys.org
In the for loops, forsooth. If b should be greater than a, why not run the for loop for b=a+1 to the max, and likewise for c.
 
Moo Of Doom said:
In the for loops, forsooth. If b should be greater than a, why not run the for loop for b=a+1 to the max, and likewise for c.

Yes, this will make the code perhaps 4 times faster in addition to removing duplicates.

To make it faster yet (and ward off potential floating-point problems) you should multiply rather than power:

Code:
main()
{
  int n,max,a,b,c;
 printf("insert the degree you wish to check for n-th pythogrean triplets\n");
 scanf("%d", &n);
 printf("insert the maximal number you want to check for\n");
 scanf("%d", &max);
 if(n > 2) {
   /* There are no solutions by the Fermat-Wiles Theorem */
 }
 elseif(max>2 && n == 2){
   for(a=1;a<max;a++) {
       for(b=a+1;b<max;b++) {
         for(c=b+1;c<=max;c++) {
           if(a*a+b*b==c*c && gcd(a,b)==1) {
             f++;
             printf("the triplet is: %d, %d, %d \n", a,b,c);
           }
         }
       }
   }
}