No, that is not correct. That would be the case if the matrix were "diagonalizable"- that is, if there were three independent eigenvectors. Ray Vickson, you can't use the same vector repeatedly. In order that P be invertible, the rows have to be indendent vectors. Eigenvectors corresponding to distinct eigenvalues are always independent so a matrix having three distinct eigenvalues is always diagonalizable but that is not the case here.
Yes, \lambda= -1 is a triple root of the characteristic equation. That means that (A+ I)^3v= 0 for every vector (a matrix always satifies its own characteristic equation. In particular, there must exist v such that Av= -v- i.e. v is an eigenvalue. It is easy to show that v= <1, 2, 1> is such an eigenvector, as you say, but we only get one such. That is why the matrix is not diagonalizable. At this point we know that the Jordan Normal form is
\begin{bmatrix}-1 & 1 & 0 \\ 0 & -1 & 1 \\ 0 & 0 & 1\end{bmatrix}.
(If there had been three independent eigenvectors, it would be diagonal:
\begin{bmatrix}-1 & 0 & 0 \\ 0 & -1 & 0 \\ 0 & 0 & 1\end{bmatrix}
If there had been two independent eigenvectors, it would have had only one "block":
\begin{bmatrix}-1 & 1 & 0 \\ 0 & -1 & 0\\ 0 & 0 & 1\end{bmatrix}.)
Since there are no other independent eigenvectors, we look for "generalized eigenvectors". There may be vectors, v, such that that it is not true that (A+ I)v= 0 but that (A+ I)^2v= 0. That is the same as (A+ I)u= 0 where u= (A+ I)v so that u is an eigenvector since every eigenvector is a multiple of <1, 4, -1> so we look for a vector, v, such that (A+ I)v= <1, 2, 1>.
The matrix equation, (A+ I)v= <1, 2, 1> or
\begin{bmatrix}1 & 0 & -1 \\ 1 & 1 & -3\\ 0 & 1 & -2\end{bmatrix}\begin{bmatrix}x \\ y \\ z\end{bmatrix}= \begin{bmatrix}x- z \\ x+ y- 3z \\ y- 2z\end{bmatrix}= \begin{bmatrix}1 \\ 2 \\ 1\end{bmatrix}
gives the three equations x- z= 1, x+ y- 3z= 2, and y- 2z= 1. From the first equation, x= z+ 1. From the third equation, y= 2z+ 1. Putting those into the second equation, z+ 1+ 2z+ 1- 3z= 2 is satisfied for any z. Taking z= 1, x= 2, and y= 3. One "generalized eigenvector" is <2, 3, 1>.
But since (A+ I)^3v= 0 for all v, there must also be v such that neither (A+ I)v= 0 nor (A+I)^2v= 0 but (A+I)^3v= 0 and that, in turn, means such that (A+ I)v is a multiple of <2, 3, 1>.
The last, independent, generalized eigenvector must satisfy (A+ I)v= <2, 3, 1> or
\begin{bmatrix}1 & 0 & -1 \\ 1 & 1 & -3\\ 0 & 1 & -2\end{bmatrix}\begin{bmatrix}x \\ y \\ z\end{bmatrix}= \begin{bmatrix}x- z \\ x+ y- 3z \\ y- 2z\end{bmatrix}= \begin{bmatrix}2 \\ 3\\ 1\end{bmatrix}
Solve for x, y, z and construct the matrix P using those vectors as columns.