Static Variables: Are They Really Static?

[ptabor]

I am doing some work using static variables - and they apparently aren't static.

void function ( arguments ) {

static float Y_kn[101][7];

if (first time through) {
initialize Y_kn
return;
}
use Y_kn to make some calculations
}

this function is called many many times (hundreds) and for the first time through Y_kn gets initialized properly. On subsequent calls the array is set to all zeros. I could initialize it every time I go through, but I thought that was the point of static variables - initialize them once and they keep the same values for the duration of the program.

This is being compiled on a unix system using mpiCC


Perhaps someone can provide some insight, because I'm stumped.

 

[haki]

Just out of curiosity how can you have a static variable declared within a method? Tought that is not possible.

function void something(...){

static int xyz = ...;

}

Shouldn't one do

static int xyz = ...

function void something(...){

xyz = ...;

}

instead?

 

[rcgldr]

Static variables are initialized to zero by default, unless explicitly initialized in the declaration statement. What is happening in your case is the compiler is generating code to re-zero out the static variables each time the function is called. I'm not sure what the "proper" behavior for static variables inside a function is. As mentioned, try moving the static variable(s) outside the function and they should only get zeroed (or initialized) at startup time.

 

[caslav.ilic]

Given that you are using MPI, it could be that the "first time through" condition is only valid once in one process, whereas you have as many default initializations as there are processes. Is the problem persisting if you use only one process?

In any case, conforming C++ compiler should not reinitialize to zeros on each function invocation, and it is generally not a good idea to put the variable outside (cluttering the global level).

--
Chusslove Illich (Часлав Илић)

 

[Hurkyl]

It's hard to tell what you did wrong without seeing the code. Could you make a small example that exhibits the behavior you're seeing, and post it to the forum?

Is your program multithreaded? Have you safeguarded against race conditions? How are you determining when it's the first time through, and when it's not?

 

[AlephZero]

The following behaves correctly (I think) using Borland C:

#include <iostream>
using namespace std;

void f(bool first)
{
	static int x;

	if (first) 
		x = 123;
	cout << x << '\n';
}

void main()
{
	f(false);
	f(true);
	f(false);
	f(true);
}

The output being
0
123
123
123