Combination is not working correctly -- fortran 90

[Md. Abde Mannaf]

!subprogram for combination
!Author:: mannaf

function fact(n)
    implicit none
   integer ::fact,n,i
    fact=1
     do i=1,n
        fact=fact*i
    end do
    return
    end

program comb
    implicit none
    integer ::fact,n,r,combination
    print*,'enter the value of nCr'
    read*,n,r
if ( n>=0 .and. r>=0 .and. n>=r) then
combination=fact(n)/(fact(n-r)*fact(r))
print*,'combination is =',combination
else
    print*,'combination is not possible  '
end if

end program

when we input n=13,r=2 then result is not correct? how to solve?

 

[berkeman]

!subprogram for combination
!Author:: mannaf

function fact(n)
    implicit none
   integer ::fact,n,i
    fact=1
     do i=1,n
        fact=fact*i
    end do
    return
    end

program comb
    implicit none
    integer ::fact,n,r,combination
    print*,'enter the value of nCr'
    read*,n,r
if ( n>=0 .and. r>=0 .and. n>=r) then
combination=fact(n)/(fact(n-r)*fact(r))
print*,'combination is =',combination
else
    print*,'combination is not possible  '
end if

end program

when we input n=13,r=2 then result is not correct? how to solve?

What is the problem statement? What is the code supposed to do?

BTW, I've enclosed your program in "code" tags -- it helps the readability a lot. Just use [ code ] and [ /code ] (without the spaces) around your program code when posting here.

 

[FactChecker]

13! = 6,227,020,800. If the default largest signed integer allowed is Int32, that is 2,147,483,647. So Int32 is not large enough to hold the number 13! You need to specify that fact is int64. That will allow signed integers up to 9,223,372,036,854,775,807. That will be large enough for 20!, but not for 21!. You can still calculate larger combinatorial expressions, but you will have to cancel common factors of numerator and denominator to avoid such large factorials.

 

[Mark44]

!subprogram for combination
!Author:: mannaf

function fact(n)
    implicit none
   integer ::fact,n,i
    fact=1
     do i=1,n
        fact=fact*i
    end do
    return
    end

program comb
    implicit none
    integer ::fact,n,r,combination
    print*,'enter the value of nCr'
    read*,n,r
if ( n>=0 .and. r>=0 .and. n>=r) then
combination=fact(n)/(fact(n-r)*fact(r))
print*,'combination is =',combination
else
    print*,'combination is not possible  '
end if

end program

when we input n=13,r=2 then result is not correct? how to solve?

What did you get for a result? The correct answer is 78.

Your factorial function looks OK, although it doesn't give the correct answer for 0!, which is 1, by definition.

Edit: As FactChecker notes, 13! will overflow the capacity of a 4-byte signed integer.

 

[theodoros.mihos]

If you need large numbers try to define nfactorial as real.

 

[SteamKing]

!subprogram for combination
!Author:: mannaf

function fact(n)
    implicit none
   integer ::fact,n,i
    fact=1
     do i=1,n
        fact=fact*i
    end do
    return
    end

program comb
    implicit none
    integer ::fact,n,r,combination
    print*,'enter the value of nCr'
    read*,n,r
if ( n>=0 .and. r>=0 .and. n>=r) then
combination=fact(n)/(fact(n-r)*fact(r))
print*,'combination is =',combination
else
    print*,'combination is not possible  '
end if

end program

when we input n=13,r=2 then result is not correct? how to solve?

If you try to calculate combinations by a "brute force" method, like trying to compute nCr = n! / [(n-r)! * r!], as you have found, you will run into issues of precision when evaluating factorials of large numbers. This is a side effect of using only a fixed number of bytes to represent fixed point (integer) or floating point (real) numbers.

By analyzing the formula for calculating a combination, we can see that computing the factorials in the numerator and denominator and then doing the division leads to a certain number of cancellations. Why not exploit this situation and only calculate the terms in the combination formula which do not cancel?

 

[gsal]

Here it is, purposely put together in an unacceptable fashion, so make sure to work your way out of this one

program comb
    integer i, n, r
    read(*,*) n, r
    if ( n >= 0 .and. r >= 0 .and. n>=r ) then
        write(*,*) 'Number of combinations is =', torial()/fact()
    else
        write(*,*) "No can do"
    end if    
contains
integer function fact()
    fact = 1      
    do i = 1, r
        fact = fact*i    
    end do    
end function fact
integer function torial()
    torial = 1      
    do i = n-r+1, n        
        torial = torial*i    
    end do    
end function torial
end program comb