Solving a Problem with Bisection Method (C Program)

[swty todd]

here is the c program for arriving at a solution using bisection method.
The ouputi s going infinte..pls help ...i think it has more of syntax errors than logical errors...

main()
{
	float a,b,c,x1,x2,x,series;
	double d;

	printf("enter a,b,c and x1(pos) & x2(neg)");
	scanf("%f%f%f%f%f", &a, &b, &c, &x1, &x2);

	read:

	x = (x1 + x2) / 2;
	series = a * x * x + b * x + c;
	d = fabs(series);

	if (d > 0.0001)
	{
		if (x * x1 < 0)
			x = x2;
		else
			x = x1;

		goto read;
	}
	else
	{
		printf("ans=%f", x);
	}

	return 0;
}

 

[shoehorn]

goto read;

Arf!

 

[Potential]

You will probably get some help faster my learning to format code so someone can read it.

main()
{
	float a,b,c,x1,x2,x,series;
	double d;

	printf("enter a,b,c and x1(pos) & x2(neg)");
	scanf("%f%f%f%f%f", &a, &b, &c, &x1, &x2);

	read:

	x = (x1 + x2) / 2;
	series = a * x * x + b * x + c;
	d = fabs(series);

	if (d > 0.0001)
	{
		if (x * x1 < 0)
			x = x2;
		else
			x = x1;

		goto read;
	}
	else
	{
		printf("ans=%f", x);
	}

	return 0;
}

 

[swty todd]

okkk
sry but thnx...

 

[rcgldr]

read:
x=(x1+x2)/2;
...
if (x*x1<0) x=x2 ; else x=x1;
goto read;

Note that you reassign x each time at "read:" so the if statement assignements have no effect. I'm not famliar with the algorithm, but you probably should be assigning x1 or x2 in your if statement:

read:
x=(x1+x2)/2;
...
if (x*x1<0) x2=x ; else x1=x;
goto read;

Would have been nice if the previous posts offered some constructive help.

 

[swty todd]

thnx...i will try my best...

 

[shoehorn]

Would have been nice if the previous posts offered some constructive help.

It would be even nicer if you decided to keep your opinions on earlier posts to yourself.

 

[swty todd]

It would be even nicer if you decided to keep your opinions on earlier posts to yourself.

yeah...dude and guess what ...it would be much more nicer if u followed what u preach

 

[swty todd]

i edited my code..bt still isn't workin..wld b glad 2 recive ur help

#include<stdio.h>
#include<math.h>
main()
{float a,b,c,x1,x2,x,series;
double d;



printf("enter a,b,c and x1(pos) & x2(neg)");
scanf("%f%f%f%f%f",&a,&b,&c,&x1,&x2);


x=0;
d=1;

 while(d>0.0001)
    {
      x=(x1+x2)/2;
      

     series=a*x*x+b*x+c;
      

     d=fabs(series);
      

         if(x*x1 < 0)
             x2=x;
         else
             x1=x;
    }

     

printf("ans=%f",x);



return 0;
}

 

[rcgldr]

The if statement should multiply the function(x1) * function(x), not x1 and x themselves. Using a new variable called series1:

series = a*x*x + b*x + c;
series1 = a*x1*x1 + b*x1 + c;
...
if (series * series1) < 0) x2 = x; else x1 = x;
...

Also note that the initial values for x1 and x2 need to be chosen so that

a*x1*x1 + b*x1 + c > 0
a*x2*x2 + b*x2 + c < 0

A parabola would have to cross the x-axis twice for this method to work, and there would be two possible answers. The initial values for x1 and x2 would have to chosen so that only one of the answers would occur in the range x1 .. x2.

 

[swty todd]

u r rite..series and series1 get multiplied and the main equation shld better not b quadratic..thnx...