I got zero also using a different method. Let's review the steps. You said
x = cos t, dx = -sint dt and t now runs from 0 to 2##\pi##.
Since cost and sint are both periodic in 2##\pi## you got zero.
What may feel wrong is that ##\int_0^{2\pi}x dx## is not zero. However, this is not the same thing as integrating x around a circle. Basically you are running cos(t) around that circle, and it's going to start and end with the same value.