Dismiss Notice
Join Physics Forums Today!
The friendliest, high quality science and math community on the planet! Everyone who loves science is here!

VC++ has gone crazy!

  1. Apr 27, 2007 #1
    My VC++ Express compiler has been acting very funnily of late.

    I tried the following code
    Code (Text):

    double sum = whatever;

    if(sum > 5.0)
        sum = 5
    else if(sum < 1.0)
        sum = 1

    The problem with this was that the program was now converting all the sum values generated into 1.0, even those which were greater than 1.0.

    Instead of using the if statement, I tried the conditional operator and then it worked fine.

    Code (Text):

    double sum = whatever;

    sum = sum > 5?  5:sum;
    sum = sum < 1?  1:sum;
    }//Working Okay
    Does anyone know the reason for this discrepancy?
  2. jcsd
  3. Apr 27, 2007 #2


    User Avatar
    Gold Member

    Well for one thing, you forgot the ';' after sum=5 / sum=1 in the first code.
  4. Apr 27, 2007 #3
    Seriously, I think the problem must be in the "whatever" (the code you didn't post). Either that, or you found a bug in the compiler.

    In any case, the code below would be far more elegant (C++ jargon for cryptic :-)

    sum = (sum > 5) ? 5 : ((sum < 1) ? 1 : sum);
  5. Apr 27, 2007 #4
    Most coding standards will fail nested ternary statements on code reviews. So try to keep it on your lab box. :-)
  6. Apr 28, 2007 #5
    Thanks for the replies.

    Actually, the statements inside the for loop constitute an inline function. This inline function is what is actually called repeatedly through the for loop. The whatever is nothing but a simple for loop (int i = 0; i < ratingCount; i++)
    I am getting another problem, this time both in VC++ and g++. I have created a structure -
    Code (Text):

    typedef  unsigned char BYTE;

    struct Data
    short MovieId;
    int CustId;
    BYTE Rating;
    float cache;
    } rt;

    cout<<sizeof(rt)<<endl;  //gives 16
    cout<<sizeof(short)+sizeof(int)+sizeof(BYTE)+sizeof(float)<<endl; //correctly gives 11

    When I use the sizeof() function to find out the size of the Data struct, it comes out to be 16 bytes instead of the 11 bytes it should be (2[short]+4[int]+1[BYTE aka char]+4[float]).
    When I summed up the individual sizes of the variables inside the struct using sizeof(float), etc., the size was correctly coming to be 11 bytes.
    Last edited: Apr 28, 2007
  7. Apr 28, 2007 #6
    I still don't really understand the code in your first post. Since you are facing a subtle, apparently compiler-dependent problem, you should post the code as written.
    Almost certainly the float (and sounds like the int as well) has to be aligned on 4-byte boundaries. That means you have a 3 byte gap between the end of the char and the start of the float, etc. If you want you struct to have the smallest size, reorder the data elements so that the largest ones are first. This is a good rule to observe whenever coding a struct or class.
  8. Apr 28, 2007 #7
    Code (Text):

    for(i = 0; i < m_nRatingCount; i++)


                    movieId = rating->MovieId;

                    custId = rating->CustId;

                    p = predictRating(rating->cache, UserFactor[f][custId], MovieFactor[f][movieId]);

                    err = rating->Rating - p;

                    sq += err*err;

                    cf = UserFactor[f][custId];

                    mf = MovieFactor[f][movieId];

                    UserFactor[f][custId] += (float)(LRATE * (err * mf - K * cf));

                    MovieFactor[f][movieId] += (float)(LRATE * (err * cf - K * mf));



    inline double predictRating(float &cache, float &UserFactor, float &MovieFactor)


        double sum = 0;

        sum = cache + UserFactor * MovieFactor;

        sum = sum > 5 ? 5:sum;//  This works but if condition does not

        sum = sum < 1 ? 1:sum;

        return sum;

    Wow, I never knew that. Happily it worked.
Share this great discussion with others via Reddit, Google+, Twitter, or Facebook