Writing a performance analyzer need really simple help with subroutines

AI Thread Summary
The discussion highlights several syntax errors and issues in a Fortran program. Key problems include the placement of the "end program" statement, which should be positioned after the main program's final "end do" statement, potentially causing the "unclassifiable statement" error. Additionally, the "implicit none" declaration in each subroutine is problematic because it requires explicit declarations for all variables used within those subroutines, which are currently missing. Other issues noted include the incorrect use of the "abs" function for matrix comparison and potential mismanagement of memory allocation and deallocation for the matrices. Overall, these errors indicate a need for improved syntax and structure in the Fortran code to ensure successful compilation and execution.
Machinus
Messages
3
Reaction score
0
I am getting a ton of errors trying to compile this. I am including PAPI and ATLAS calls but so far I think those calls are working ok.

For each subroutine, I am getting "unclassifiable statement" for the subroutine definition as well as "unexpected implicit none" and "expecting end program statement" at the end.

It also won't let me use abs to compare the matrices. I am sure my syntax is wrong but I am new to fortran and I am not sure how I am supposed to write it.

Code:
#include /mnt/scratch/sw/papi-3.6.2/include/fpapi.h

program main
implicit none

integer:: i,j,k,M,N
integer:: tinitial,tfinal
real(8):: epsilon
real(8):: r1,r2,r3,r4,r5,r6
real(8):: t1,t2,t3,t4,t5,t6
real(8), allocatable:: A(:,:),B(:,:),C(:,:),D(:,:)

epsilon = 2.22e-16

open(unit=1,file="optimization.dat")
do M=1,100

   N = 10*M

   allocate(A(N,N),B(N,N),C(N,N),D(N,N))

   call random_number(A)
   call random_number(B)
   call random_number(C)
   
   call m1(N,A,B,C,D)
   call m2(N,A,B,C,D)
   call m3(N,A,B,C,D)
   call m4(N,A,B,C,D)
   call m5(N,A,B,C,D)
   call m6(N,A,B,C,D)

   write(*,*) N,r1,r2,r3,r4,r5,r6
   write(1,*) N,t1,t2,t3,t4,t5,t6

end do

subroutine m1 (N,A,B,C,D)
implicit none
tinitial = rtime
do i=1,N
   do j=1,N
      do k=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t1 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r1 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m1

subroutine m2 (N,A,B,C,D)
implicit none
tinitial = rtime
do i=1,N
   do k=1,N
      do j=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t2 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r2 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m2

subroutine m3 (N,A,B,C,D)
implicit none
tinitial = rtime
do j=1,N
   do i=1,N
      do k=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t3 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r3 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m3

subroutine m4 (N,A,B,C,D)
implicit none
tinitial = rtime
do j=1,N
   do k=1,N
      do i=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t4 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r4 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m4

subroutine m5 (N,A,B,C,D)
implicit none
tinitial = rtime
do k=1,N
   do i=1,N
      do j=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t5 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r5 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m5

subroutine m6 (N,A,B,C,D)
implicit none
tinitial = rtime
do k=1,N
   do j=1,N
      do i=1,N
         C(i,j)=C(i,j)+A(i,k)*B(k,j)
      end do
   end do
end do
D(i,j)=C(i,j)
tfinal = rtime
t6 = tfinal-tinitial
call dgemm('No','No',N,N,N,1.0d0,A(N,N),i,B(N,N),k,1.0d0,C(N,N),i)
r6 = dlange(F,N,N,(C-D(i,j)))/(C*epsilon)
deallocate(A,B,C,D)
return
end subroutine m1

close(1)

end program

What are the obvious syntax problems and errors I am making?
 
Last edited:
Technology news on Phys.org
You have your end program in the wrong place. It and the close(1) statement should be at the end of your main program, right after the first end do. This might be what is causing the "unclassifiable statement" error.

For your implicit none statements in your subroutines, the problem might be that you're saying each subroutine has no implicitly typed parameters and variables, yet you're not declaring any of them in the subs.
 
  • Like
Likes Machinus
Dear Peeps I have posted a few questions about programing on this sectio of the PF forum. I want to ask you veterans how you folks learn program in assembly and about computer architecture for the x86 family. In addition to finish learning C, I am also reading the book From bits to Gates to C and Beyond. In the book, it uses the mini LC3 assembly language. I also have books on assembly programming and computer architecture. The few famous ones i have are Computer Organization and...
I have a quick questions. I am going through a book on C programming on my own. Afterwards, I plan to go through something call data structures and algorithms on my own also in C. I also need to learn C++, Matlab and for personal interest Haskell. For the two topic of data structures and algorithms, I understand there are standard ones across all programming languages. After learning it through C, what would be the biggest issue when trying to implement the same data...

Similar threads

Replies
12
Views
3K
Replies
20
Views
2K
Replies
3
Views
2K
Replies
2
Views
2K
Replies
4
Views
2K
Replies
22
Views
5K
Replies
2
Views
1K
Back
Top