Python [Python] Why does this loop execute 4 times?

  • Thread starter Thread starter Hercuflea
  • Start date Start date
  • Tags Tags
    Loop Python
AI Thread Summary
The discussion revolves around a coding issue where a loop in a Python function, BOUTinp_search, executes four times unexpectedly. The function reads an input file and extracts grid size parameters from lines containing specific keywords. The user initially believed the loop was malfunctioning, but it was revealed that the function was called four times in another part of the code. The user confirmed the input file had 48 lines, but they were primarily interested in the "mesh" section. Suggestions were made to remove unnecessary continue statements and consider using Python's ConfigParser for better file handling, as it could streamline the process and improve robustness.
Hercuflea
Messages
593
Reaction score
49
I've written a code which reads in an input file and extracts a number which represents a grid size, from lines in the file which can contain arbitrary characters. The extraction of the data seems to be working, but for some reason the loop executes 4 times and then moves on to the next function in my code...Why does my loop execute 4 times? I've been stuck on this for a while now.

Python: 
def BOUTinp_search():
    with open('BOUT.inp', 'r') as boutinput:
        for line in boutinput:
            if '[mesh]' in line:
                print '\nFound mesh options.'
                continue
            elif 'nx =' in line:
                xnumpts = int(filter(str.isdigit, line))
                print('Recovered number of x gr'
                'id points.')
                print 'x grid size: ', xnumpts
   
                continue
            elif 'ny =' in line:
                ynumpts = int(filter(str.isdigit, line))
                print('Recovered number of y gr'
                'id points.')
                print 'y grid size: ', ynumpts
                continue
            elif 'dx =' in line:
                dx = float(filter(str.isdigit, line))
                print 'Recovered x spacing.'
                print 'x grid spacing: ', dx
                continue

            elif 'dy =' in line:
                dy = float(filter(str.isdigit, line))
                print 'Recovered y spacing.'
                print 'y grid spacing: ', dy
                continue

    return [xnumpts, ynumpts, dx, dy]

Output:

Code: 
[me@dir]$ python file.py

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0
 
Last edited by a moderator:
Technology news on Phys.org
Hercuflea said:
I've written a code which reads in an input file and extracts a number which represents a grid size, from lines in the file which can contain arbitrary characters. The extraction of the data seems to be working, but for some reason the loop executes 4 times and then moves on to the next function in my code...Why does my loop execute 4 times? I've been stuck on this for a while now.

Python: 
def BOUTinp_search():
    with open('BOUT.inp', 'r') as boutinput:
        for line in boutinput:
            if '[mesh]' in line:
                print '\nFound mesh options.'
                continue
            elif 'nx =' in line:
                xnumpts = int(filter(str.isdigit, line))
                print('Recovered number of x gr'
                'id points.')
                print 'x grid size: ', xnumpts
  
                continue
            elif 'ny =' in line:
                ynumpts = int(filter(str.isdigit, line))
                print('Recovered number of y gr'
                'id points.')
                print 'y grid size: ', ynumpts
                continue
            elif 'dx =' in line:
                dx = float(filter(str.isdigit, line))
                print 'Recovered x spacing.'
                print 'x grid spacing: ', dx
                continue

            elif 'dy =' in line:
                dy = float(filter(str.isdigit, line))
                print 'Recovered y spacing.'
                print 'y grid spacing: ', dy
                continue

    return [xnumpts, ynumpts, dx, dy]

Output:

Code: 
[me@dir]$ python file.py

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0

Found mesh options.
Recovered number of x grid points.
x grid size:  260
Recovered number of y grid points.
y grid size:  1
Recovered x spacing.
x grid spacing:  2.0
Recovered y spacing.
y grid spacing:  1.0
How many lines are there in your input file? You have a loop that executes for each line in this file. Also, I don't see the reason for having continue statements in each of your if clauses.

BTW, I removed your "spoiler" tags. Since you're asking a question about code, having your code and output hidden by spoiler tags didn't seem very useful.
 
Mark44 said:
How many lines are there in your input file? You have a loop that executes for each line in this file. Also, I don't see the reason for having continue statements in each of your if clauses.

BTW, I removed your "spoiler" tags. Since you're asking a question about code, having your code and output hidden by spoiler tags didn't seem very useful.
Hi Mark, thanks for the input.

There are currently 48 lines in the input file, but there could be more or less based on what the user's preferences are. At the moment I'm only interested in making a Cartesian grid using one of the options called "mesh" in the input file, but I'm trying to keep it as forward-compatible as possible.
I.e. I want to loop through the entire file in case I decide to read in options from some of the other sections later.

The continue statements were basically a safeguard to make sure it only executes one and only one of the if statements at each line of the file, but I suppose they aren't necessary.
 
Well, maybe the contents of BOUTinp_search() is being executed only once; but, could it be that you are calling BOUTinp_search() four times in the first place? Can't tell, you don't show your entire code.
 
gsal said:
Well, maybe the contents of BOUTinp_search() is being executed only once; but, could it be that you are calling BOUTinp_search() four times in the first place? Can't tell, you don't show your entire code.

You were right...I was actually calling the function four times in a silly way in another function. Thanks for that.
 
Assuming your section names (like `[mesh]`) are unique, there is a component in the standard library to read files in this format. It's quicker and more robust to use it, if your file structure allows it.

https://docs.python.org/3/library/configparser.html
 

Thread 'Learning Assembly and computer architecture for x86'

Dear Peeps I have posted a few questions about programing on this sectio of the PF forum. I want to ask you veterans how you folks learn program in assembly and about computer architecture for the x86 family. In addition to finish learning C, I am also reading the book From bits to Gates to C and Beyond. In the book, it uses the mini LC3 assembly language. I also have books on assembly programming and computer architecture. The few famous ones i have are Computer Organization and...
View full post »

Thread 'Microsoft Technical Interview question'

I had a Microsoft Technical interview this past Friday, the question I was asked was this : How do you find the middle value for a dataset that is too big to fit in RAM? I was not able to figure this out during the interview, but I have been look in this all weekend and I read something online that said it can be done at O(N) using something called the counting sort histogram algorithm ( I did not learn that in my advanced data structures and algorithms class). I have watched some youtube...
View full post »

Similar threads

Python relativity game in python
Replies
4
Views
1K
Python Python "ImportError: bad magic number ...."
Replies
1
Views
4K
Python Entropy calculation atoms simulation
Replies
1
Views
1K
Python What's wrong with this Python program on Euler's forward algorithm?
Replies
2
Views
2K
(CFD) Problem with C code for 1D linear convection equation
Replies
1
Views
2K
Python Numerical integration over a disk with polar coordinates
Replies
5
Views
3K
Python Need help with random walk simulation on a Manhattan grid in Python?
Replies
4
Views
3K
Python What is the Nelder-Mead algorithm and how can it be implemented in pure Python?
Replies
3
Views
4K
Python Lorenz ODE solver in 35 lines of pure Python
Replies
17
Views
3K
WaveGrid - Non-equilibrium Emergence Sandbox
Replies
1
Views
2K

Hot Threads

Recent Insights

Back
Top