Sorry to dig up this old thread, but I came across this post when trying to find out which units to use and thought I should add the correct answer now I've found it.
Radiative Processes in Astrophysics by Rybicki and Lightman (p29) defines the transition probability per unit time ([itex]\mathrm{s}^{-1}[/itex]) for stimulated emission as [itex]B_{21}\overline{J}[/itex], where [itex]\overline{J}[/itex] is the mean intensity ([itex]\mathrm{Jm^{-2}s^{-1}sr^{-1}Hz^{-1}}[/itex]). This gives [itex]B_{21}[/itex] in units of [tex]\mathrm{m^2 sr J^{-1} s^{-1}}[/tex] However, the book also states that the energy density [itex]u_\nu[/itex] is often used instead of [itex]J_\nu[/itex] to define the Einstein B-coefficients. [tex]u_\nu=\frac{4\pi}{c}J_\nu[/tex] where [itex]J_\nu[/itex] is in the same units as [itex]\overline{J}[/itex] and therefore the units of [itex]u_\nu[/itex] are [itex]\mathrm{Jm^{-3}sr^{-1}Hz^{-1}}[/itex]. Therefore if the transition probability is defined as [itex]B_{21}\overline{u}[/itex] (with [itex]\overline{u}[/itex] again in the same units as [itex]u_\nu[/itex]) then the units of [itex]B_{21}[/itex] become [tex]\mathrm{m^3 sr J^{-1} s^{-2}}[/tex] So both of you were correct! Just make sure you stick to one definition or the other.