Need help soon with C++ program using pointers and arrays

  • #1
Okay so I got the majority of my program complete, however when I try to run it it doesnt display the proper value of the average. I think I somehow messed up using my pointers and arrays, but I cant locate the problem and ive spent hours trying to fix it to no avail. see comments for better description of program.

-------

#include <iostream>

using namespace std;

/* Write a program to read in a series of numbers and display how many
are greater than their average. The user will indicate that there are no more numbers.
by entering a -999. This lab requires that you use new and delete. */

int main ( )
{
// Declaration of variables
int index = 0;
int count = 0;
int amount = 0;
int sum = 0;
int capacity = 2;
int * number;
number = new int[capacity];

// Puts the numbers the user enters into an array
// Keeps track of their sum;
// Keeps track of the numbers entered;
while(true)
{
cout <<"Enter a number: ";
cin >> number[index];

if (number[index] == -999)break;

sum = sum + number[index];
amount++;

if (index == capacity)
{
int * tmp = new int[capacity];
number = tmp;
delete []tmp;
}

index++;
}

// Accumulator variable to count numbers larger than average
for (index = 0; index <= amount; index++)
{
if (number[index] > (sum / amount)) count++;
}

// Output
cout << "There are " << count
<< " numbers greater than their average." << endl;


return 0;
}
 

Answers and Replies

  • #2
mgb_phys
Science Advisor
Homework Helper
7,774
13
Several problems,
You create an array with 2 items, but you use elements greater than 0 or 1.
You create a new array to exapand it, but the new array is the same size and you don't copy the data to the new array you copy the pointer.
You create an array, copy the pointer and then delete the array, the memory the number pointer points at is no longer valid.

You have most of the ideas correct,
Allocate an array of a reasonable size 100 or 1000 entries if the user is entering them by hand.
Keep track of how many number have been entered and if you have to allocate more space make a new array twice the size of the old one and copy the data using either memcpy() or just looping through the values.

ps. Be careful about the result of dividing one integer by another.
 
Last edited:
  • #3
Hurkyl
Staff Emeritus
Science Advisor
Gold Member
14,916
19
At the office, if you run out of filing cabinet space, you might seek to increase your capacity. What's wrong with the following directions for doing so?

1. Acquire new filing cabinet.
2. Install new filing cabinet.
3. Put old filing cabinet in the dumpster.

(Hint: think very literally)
 
  • #4
Several problems,
You create an array with 2 items, but you use elements greater than 0 or 1.
You create a new array to exapand it, but the new array is the same size and you don't copy the data to the new array you copy the pointer.
You create an array, copy the pointer and then delete the array, the memory the number pointer points at is no longer valid.

You have most of the ideas correct,
Allocate an array of a reasonable size 100 or 1000 entries if the user is entering them by hand.
Keep track of how many number have been entered and if you have to allocate more space make a new array twice the size of the old one and copy the data using either memcpy() or just looping through the values.

ps. Be careful about the result of dividing one integer by another.
hm.. I think I can go on this. I'm supposed to start with 2 "elements" for the array and allocate 2 more spaces for the "elements" each time they are filled up...
and I'm supposed to use pointers or something.

I can change them to double no problem though.
 
  • #5
mgb_phys
Science Advisor
Homework Helper
7,774
13
Even if you only allocate 2 extra elements at a time, you still have to copy the old values to the new array before deleting the old array.
 
  • #6
Even if you only allocate 2 extra elements at a time, you still have to copy the old values to the new array before deleting the old array.
do I use pointers to do this?

EDIT: "memcpy() or just looping through the values."
I've never used memcpy() before and am unfamiliar with it. Should I use a for loop to copy the old values? How do I go about doing this?

if (index == capacity)
{
capacity = capacity + 2;
int * tmp = new int[capacity];
number = tmp;
delete []tmp;
}

I added capacity = capacity + 2 each time this if loop runs through, that way when the whole for loop repeats, it has allocated 2 more memory.. I think. Not sure about how to copy data though.
 
  • #7
OrbitalPower
You should be able to access the values of the old array, copy them in, as they exist in the memory, and then delete it after the for loop, as you would if you were to take a pointer to an int value and store it another pointer to int, and then delete it. So yes it's possible
 

Related Threads on Need help soon with C++ program using pointers and arrays

  • Last Post
Replies
10
Views
3K
Replies
6
Views
6K
Replies
2
Views
10K
  • Last Post
Replies
20
Views
4K
  • Last Post
Replies
16
Views
3K
  • Last Post
Replies
3
Views
1K
  • Last Post
Replies
0
Views
2K
  • Last Post
Replies
3
Views
3K
Replies
4
Views
4K
Top